Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remaps for cob4 as comments #82

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

ipa-nhg
Copy link
Member

@ipa-nhg ipa-nhg commented May 12, 2016

No description provided.

<node pkg="cob_obstacle_distance_moveit" type="obstacle_distance_node" name="$(arg node_name)" output="screen"/>

<node pkg="cob_obstacle_distance_moveit" type="obstacle_distance_node" name="$(arg node_name)" output="screen">
<!--remap from="/obstacle_distances" to="/obstacle_distances"/--> <!--only needed for the cob4 specific configuration-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remap doesn't do anything, does it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, it has an extra "/" I just copied from https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_bringup/tools/obstacle_distance_monitor.launch#L26 because I opened a pull request to remove the file https://github.com/ipa320/cob_robots/pull/478/files and I wanted to save the remap information.

@floweisshardt
Copy link
Member

@ipa-nhg: what's the status here? merge? close?

@floweisshardt
Copy link
Member

ok, so that's good to be merged

@floweisshardt floweisshardt merged commit ecc8b96 into ipa320:indigo_dev Aug 10, 2016
@mathias-luedtke
Copy link
Contributor

CR: not okay

@fmessmer
Copy link
Member

I bet the functionality is broken now! Whatever...seems no one knows how to use it or cares about it...

@mgruhler
Copy link
Member

@ipa-fmw @ipa-nhg @ipa-mdl how to proceed with this? There has been a

CR: not okay

from @ipa-mdl...

@floweisshardt
Copy link
Member

I think nothing is broken through this PR as it does nothing except adding comments! We should find a proper solution how to proceed including cob_moveit_config, bringup dependency to moveit before continuing... see #518 and #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants