This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add contributing documentation #319
Add contributing documentation #319
Changes from 1 commit
6916516
459e684
5558c32
782873e
43f0911
05d82de
5b49373
8010d66
40c0130
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Just confirming, are we planning to migrate
docs
directory in this project to the documentation repo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, yes I think that would be a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that would be great!
@JakeSCahill do you have any suggestions how to make this happen? The complete documentation is built via sphinx from
.rst
files, and I'm afraid rewriting everything into.md
files for docs.iota.org would mean abandoning sphinx, and hence loosing automatic doc generation from source code. Sphinx is essential for maintainable python documentation.Or could we create a custom html theme for shpinx in order to include the output html files directly into
iotaledger/documentation
?Another option would be to create a new
md
file specifically for the docs site with only the API methods (core + extended), but leave the in depth-documentation at https://pyota.readthedocs.io/en/latest/ .What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Maybe add a bit here suggesting people discuss feature ideas on Discord for the best chance of getting approved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mention this in the contributing guidelines.
I'd prefer to keep the template clean to reduce the amount of content, which might put people off.
If you think it's important, feel free to add it though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Which page will the contributor links appear on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. This was written by our security specialist @karimodm
Maybe this should say
on this page
?