Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Add contributing documentation #319

Merged
merged 9 commits into from
Mar 19, 2020

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Mar 16, 2020

Add docs to .github directory to keep the repo tidy.

Updates the templates to use the latest GitHub features.

@JakeSCahill JakeSCahill changed the title Add conttributing documentation Add contributing documentation Mar 16, 2020
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ some suggestions+questions.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
<summary>Contribute to the documentation :black_nib:</summary>
<br>

The Python client library documentation is hosted on https://docs.iota.org, which is built from content in the [documentation](https://github.com/iotaledger/documentation) repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Just confirming, are we planning to migrate docs directory in this project to the documentation repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, yes I think that would be a good idea.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that would be great!
@JakeSCahill do you have any suggestions how to make this happen? The complete documentation is built via sphinx from .rst files, and I'm afraid rewriting everything into .md files for docs.iota.org would mean abandoning sphinx, and hence loosing automatic doc generation from source code. Sphinx is essential for maintainable python documentation.
Or could we create a custom html theme for shpinx in order to include the output html files directly into iotaledger/documentation?
Another option would be to create a new md file specifically for the docs site with only the API methods (core + extended), but leave the in depth-documentation at https://pyota.readthedocs.io/en/latest/ .
What do you think?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/SECURITY.md Outdated Show resolved Hide resolved
.github/SECURITY.md Outdated Show resolved Hide resolved
.github/SECURITY.md Outdated Show resolved Hide resolved
<li>We will respond to your report within 3 business days with our evaluation of the report and an expected resolution date.</li>
<li>If you have followed the instructions above, we will not take any legal action against you in regard to the report.</li>
<li>We will keep you informed during all stages of resolving the problem.</li>
<li>To show our appreciation for your effort and cooperation during the report, we will list your name and a link to a personal website/social network profile on the page below so that the public can know you've helped keep the IOTA Foundation secure.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Which page will the contributor links appear on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. This was written by our security specialist @karimodm

Maybe this should say on this page?

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Member

@lzpap lzpap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JakeSCahill , lgtm!

<summary>Contribute to the documentation :black_nib:</summary>
<br>

The Python client library documentation is hosted on https://docs.iota.org, which is built from content in the [documentation](https://github.com/iotaledger/documentation) repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that would be great!
@JakeSCahill do you have any suggestions how to make this happen? The complete documentation is built via sphinx from .rst files, and I'm afraid rewriting everything into .md files for docs.iota.org would mean abandoning sphinx, and hence loosing automatic doc generation from source code. Sphinx is essential for maintainable python documentation.
Or could we create a custom html theme for shpinx in order to include the output html files directly into iotaledger/documentation?
Another option would be to create a new md file specifically for the docs site with only the API methods (core + extended), but leave the in depth-documentation at https://pyota.readthedocs.io/en/latest/ .
What do you think?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@todofixthis todofixthis changed the base branch from master to develop March 18, 2020 19:04
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@lzpap lzpap merged commit b1b068f into iotaledger:develop Mar 19, 2020
@lzpap lzpap mentioned this pull request Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants