Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Github Actions Caching #1419

Merged
merged 20 commits into from
Jun 15, 2021
Merged

Enable Github Actions Caching #1419

merged 20 commits into from
Jun 15, 2021

Conversation

georgysavva
Copy link
Contributor

@georgysavva georgysavva commented Jun 8, 2021

Fixes: #890

plugins/gossip/gossip.go Outdated Show resolved Hide resolved
plugins/gossip/gossip.go Outdated Show resolved Hide resolved
plugins/gossip/gossip.go Outdated Show resolved Hide resolved
@georgysavva
Copy link
Contributor Author

After running several benchmarks it turned out that docker layer caching doesn't give any performance benefit due to the fact that we can not cache the Go build. So we should get back this when they fix that in moby/buildkit#1512

Let's merge this PR anyway to at least have a working example with Github Actions cache for docker :)

@georgysavva georgysavva changed the title WIP Enable Github Actions Caching Enable Github Actions Caching Jun 8, 2021
.github/workflows/docker-develop.yml Outdated Show resolved Hide resolved
.github/workflows/docker-develop.yml Outdated Show resolved Hide resolved
@jkrvivian jkrvivian added this to the v0.7.1 milestone Jun 10, 2021
…in-CI

# Conflicts:
#	.github/workflows/integration-tests.yml
@capossele capossele merged commit 167c7ef into develop Jun 15, 2021
@capossele capossele deleted the feat/docker-cache-in-CI branch June 15, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable caching for integration tests
4 participants