Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caching for integration tests #890

Closed
jonastheis opened this issue Dec 15, 2020 · 4 comments · Fixed by #1419
Closed

Enable caching for integration tests #890

jonastheis opened this issue Dec 15, 2020 · 4 comments · Fixed by #1419

Comments

@jonastheis
Copy link
Contributor

If we enable caching via any of these options we should be able to speed up at least the pulling of dependencies and building by a large margin.

This already takes a little bit longer than 3min.

image

@georgysavva
Copy link
Contributor

It seems that the article that you mentioned is a bit old.
Here are the official docket GH actions to achieve image layers caching via Github caching:
https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md
And complete third-party article as a bonus:
https://evilmartians.com/chronicles/build-images-on-github-actions-with-docker-layer-caching
I will try to pull this off.

@georgysavva
Copy link
Contributor

@capossele Why did we close this issue?

@capossele
Copy link
Contributor

My bad, I thought we were done with this. I'll reopen it

@capossele capossele reopened this Apr 1, 2021
@georgysavva georgysavva self-assigned this Jun 8, 2021
@jkrvivian jkrvivian added this to the v0.7.1 milestone Jun 8, 2021
@georgysavva
Copy link
Contributor

After running several benchmarks it turned out that docker layer caching doesn't give any performance benefit due to the fact that we can not cache the Go build. So we should get back this when they fix that in moby/buildkit#1512
@jonastheis

@jonastheis jonastheis removed this from the v0.7.1 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants