Fix broken links #259

ocefpaf · 2023-08-18T20:17:51Z

This one is ready but it is best merged after #212 so we can test the GHA here.

1. Status 0 seems to be related to result.statusCode: 0 being returned by many external links tcort/markdown-link-check#220
2. Status 400 are local references that exists but the checker is failing somehow
3. Fix all the references to kerfoot pages
4. Re-check the changed links to ensure they are showing the expected info from before

ERROR: 9 dead links found in _docs/glider-background-and-sampling-terminology.md !
[✖] https://apl.uw.edu/project/project.php?id=seaglider#:~:text=The → Status: 0
[✖] https://github.com/kerfoot/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.cdl → Status: 404
[✖] https://github.com/kerfoot/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.nc → Status: 404
[✖] https://github.com/kerfoot/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.ncml → Status: 404
[✖] https://github.com/kerfoot/glider-dac/tree/master/nc/template → Status: 404
[✖] ngdac-netcdf-file-format-version-2.html → Status: 400
[✖] /glider-dac/glider-sampling-terminology.png → Status: 400

ERROR: 3 dead links found in _docs/index.md !
[✖] /glider-dac/ngdac-netcdf-file-format-version-2.html → Status: 400
[✖] glider-background-and-sampling-terminology.html#sampling-pattern-terminology → Status: 400

ERROR: 6 dead links found in _docs/ngdac-netcdf-file-format-version-2.md !
[✖] /glider-dac/ngdac-netcdf-file-submission-process.html → Status: 400
[✖] https://github.com/ioos/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.nc → Status: 404
[✖] https://github.com/ioos/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.cdl → Status: 404
[✖] https://github.com/ioos/glider-dac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.ncml → Status: 404
[✖] https://github.com/ioos/glider-dac/tree/master/nc/template → Status: 404

ERROR: 5 dead links found in _docs/useful-links.md !
[✖] ngdac-netcdf-file-format-version-2.html → Status: 400
[✖] https://compliance.ioos.us/index.html → Status: 502
[✖] https://github.com/ioos/glider-dac/blob/master/util/ncFtp2ngdac.pl → Status: 404
[✖] /glider-dac/ngdac-netcdf-file-submission-process.html#new-deployment-registration → Status: 400

ERROR: 1 dead links found in _docs/data-workflow.md !
[✖] https://www.ndbc.noaa.gov/gliders.php → Status: 404

ERROR: 7 dead links found in _docs/glider-dac-communications-plan.md !
[✖] https://github.com/ioos/glider-dac-catalog → Status: 404
[✖] https://github.com/ioos/glider_dac_thredds_catalog%3E → Status: 404
[✖] http://www.ioos.noaa.gov/observing/observing_assets/glider_asset_map.html → Status: 404
[✖] https://gliders.ioos.us/metadata-erddap/ → Status: 404
[✖] https://gliders.ioos.us/metadata-thredds/ → Status: 404
[✖] http://www.ndbc.noaa.gov/gliders.php → Status: 404
[✖] https://raw.githubusercontent.com/kerfoot/glider-dac/master/doco/IOOS-DAC-architecture.png → Status: 404

ERROR: 1 dead links found in _docs/ngdac-architecture.md !
[✖] /glider-dac/IOOS-DAC-architecture.png → Status: 400

ERROR: 11 dead links found in _docs/ngdac-netcdf-file-submission-process.md !
[✖] /glider-dac/useful-links → Status: 400
[✖] ngdac-netcdf-file-format-version-2.html#description--examples-of-required-global-attributes → Status: 400
[✖] ngdac-netcdf-file-format-version-2.html#platform → Status: 400
[✖] ngdac-netcdf-file-format-version-2.html#trajectory → Status: 400
[✖] ngdac-netcdf-file-submission-process.html#dataset-archiving → Status: 400
[✖] ngdac-netcdf-file-format-version-2.html#file-naming-conventions → Status: 400
[✖] https://github.com/ioos/glider-dac/blob/master/util/ncFtp2ngdac.pl → Status: 404
[✖] /glider-dac/ngdac-architecture.html#data-assembly-center-architecture → Status: 400
[✖] https://compliance.ioos.us/index.html → Status: 502
[✖] /glider-dac/DAC_providers_your_deployments.png → Status: 400
[✖] /glider-dac/DAC_complete_deployment.png → Status: 400

ocefpaf · 2023-08-18T23:42:12Z

The https://compliance.ioos.us/index.html broken link is on us:

ocefpaf · 2023-08-19T00:04:47Z

For 3 we need to check:

find . -type f -name "*.md" -exec grep "kerfoot" '{}' \; -print  | grep \.\/    

> [Wiki](https://github.com/kerfoot/ioosngdac/wiki) ▸ **Glider Background and Sampling Terminology**
<!-- ![Glider Sampling Patterns and Terms](https://raw.githubusercontent.com/kerfoot/ioosngdac/master/doco/glider-sampling-terminology.png) -->
 + **Profile**: A single vertically oriented track of a glider, either upward or downward through the water column.  A profile is one-half of a **dive**.  The profile is the fundamental atomic data type used by the **NGDAC**.  All data submitted to the **NGDAC** is submitted as individual profiles, containing the various water column properties or sensor values.  Examples of the file format description can be found as [CDL](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.cdl), [NetCDF file](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.nc) and [ncml](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.ncml) can be found [here](https://github.com/kerfoot/ioosngdac/tree/master/nc/template).
./glider-background-and-sampling-terminology.md

> [Wiki](https://github.com/kerfoot/glider-dac/wiki) ▸ **Data Provider Links**
./useful-links.md

> [Wiki](https://github.com/kerfoot/ioosngdac/wiki) ▸ **NGDAC File Submission Process**
./ngdac-netcdf-file-submission-process.md

> [Wiki](https://github.com/kerfoot//glider-dac//wiki) ▸ **NGDAC Architecture**
./ngdac-architecture.md

The first one we need to decided what are we doing with the files their are pointing to:

The rest are all links to the wiki. I believe the wiki will be retired so we need to edit these pages to reflect that.

_docs/data-workflow.md

_docs/faqs.md

_docs/glider-background-and-sampling-terminology.md

_docs/glider-dac-communications-plan.md

_docs/index.md

_docs/data-workflow.md

_docs/index.md

…ion-system-gts

ocefpaf · 2023-08-28T18:30:51Z

_docs/glider-background-and-sampling-terminology.md

 ![Glider Sampling Patterns and Terms](/glider-dac/glider-sampling-terminology.png)

- + **Profile**: A single vertically oriented track of a glider, either upward or downward through the water column.  A profile is one-half of a **dive**.  The profile is the fundamental atomic data type used by the **NGDAC**.  All data submitted to the **NGDAC** is submitted as individual profiles, containing the various water column properties or sensor values.  Examples of the file format description can be found as [CDL](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.cdl), [NetCDF file](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.nc) and [ncml](https://github.com/kerfoot/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.ncml) can be found [here](https://github.com/kerfoot/ioosngdac/tree/master/nc/template).
+ + **Profile**: A single vertically oriented track of a glider, either upward or downward through the water column.  A profile is one-half of a **dive**.  The profile is the fundamental atomic data type used by the **NGDAC**.  All data submitted to the **NGDAC** is submitted as individual profiles, containing the various water column properties or sensor values.  Examples of the file format description can be found as [CDL](/glider-dac/nc/template/IOOS_Glider_NetCDF_v2.0.cdl), [NetCDF file](/glider-dac/nc/template/IOOS_Glider_NetCDF_v2.0.nc) and [ncml](/glider-dac/nc/template/IOOS_Glider_NetCDF_v2.0.ncml) can be found [here](https://github.com/ioos/glider-dac/tree/gh-pages/nc/template).


I'll probably have to iterate on this relative link. I'm not sure how Jekyll behaves on local vs remote builds. (It has been a while that I used it.) Regardless, after this one is merged, I should probably change these to full links instead of relative ones.

ocefpaf · 2023-08-28T21:09:30Z

_docs/useful-links.md

@@ -29,42 +29,36 @@ The following is a list of links for data providers and web applications develop

  The IOOS Compliance Checker is a python based tool for data providers to check for completeness and community standard compliance of local or remote netCDF files against metadata standards. This web based tool can be used to check your GliderDAC netCDF files for compliance. Be sure to select **GliderDAC** in the list of available tests to run.

- - [**FTP script**](https://github.com/ioos/glider-dac/blob/master/util/ncFtp2ngdac.pl)


@benjwadams can you give your 👍 or 👎 here? As far as I remember this is deprecated, right?

kbailey-noaa

Numerous comments throughout about link changes and some minor text updates.

_docs/index.md

_docs/ngdac-architecture.md

_docs/ngdac-netcdf-file-format-version-2.md

kbailey-noaa · 2023-08-28T20:31:36Z

_docs/ngdac-netcdf-file-format-version-2.md

@@ -94,7 +94,7 @@ Ideally, the <strong>glider_yyyymmddTHHMMSS.nc</strong> files will be provided b
 ## Global Attributes

 The following is the list of required global attributes that must be included in each NetCDF file submitted to the **NGDAC**. This list was created from a variety of sources with the goal of providing a complete metadata record of the data set. More information on these sources can be found at the following locations:
- - **CF1.6**: Section 2.6 of v1.6 Climate and Forecast [conventions](http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html)
+ - **CF1.6**: Section 2.6 of v1.6 Climate and Forecast [conventions](https://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html
 - **ACDD**: Attribute Conventions for Dataset Discovery [Home page](http://wiki.esipfed.org/index.php?title=Category:Attribute_Conventions_Dataset_Discovery) and [Current Standard](http://wiki.esipfed.org/index.php/Attribute_Convention_for_Data_Discovery_%28ACDD%29)


Change to:
Attribute Convention for Data Discovery (ACDD)

kbailey-noaa · 2023-08-28T20:35:34Z

_docs/ngdac-netcdf-file-format-version-2.md

@@ -94,7 +94,7 @@ Ideally, the <strong>glider_yyyymmddTHHMMSS.nc</strong> files will be provided b
 ## Global Attributes

 The following is the list of required global attributes that must be included in each NetCDF file submitted to the **NGDAC**. This list was created from a variety of sources with the goal of providing a complete metadata record of the data set. More information on these sources can be found at the following locations:
- - **CF1.6**: Section 2.6 of v1.6 Climate and Forecast [conventions](http://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html)
+ - **CF1.6**: Section 2.6 of v1.6 Climate and Forecast [conventions](https://cfconventions.org/cf-conventions/v1.6.0/cf-conventions.html
 - **ACDD**: Attribute Conventions for Dataset Discovery [Home page](http://wiki.esipfed.org/index.php?title=Category:Attribute_Conventions_Dataset_Discovery) and [Current Standard](http://wiki.esipfed.org/index.php/Attribute_Convention_for_Data_Discovery_%28ACDD%29)
 - **NCEI**: Guidance from NOAA's National Centers for Environmental Information on netCDF templates to promote good stewardship and archiving. [NCEI Templates](http://www.nodc.noaa.gov/data/formats/netcdf/) and [global attribute suggestions](http://www.nodc.noaa.gov/data/formats/netcdf/#guidancetable).


Change to:
NOAA National Centers for Environmental Information (NCEI) netCDF Templates: Guidance from NCEI on netCDF templates to promote good stewardship and archiving. NCEI Templates and global attribute suggestions.

_docs/useful-links.md

kbailey-noaa · 2023-08-28T21:17:20Z

_docs/useful-links.md

@@ -29,7 +29,7 @@ The following is a list of links for data providers and web applications develop

  The IOOS Compliance Checker is a python based tool for data providers to check for completeness and community standard compliance of local or remote netCDF files against metadata standards. This web based tool can be used to check your GliderDAC netCDF files for compliance. Be sure to select **GliderDAC** in the list of available tests to run.

- - [**FTP script**](https://github.com/ioos/ioosngdac/blob/master/util/ncFtp2ngdac.pl)
+ - [**FTP script**](https://github.com/ioos/glider-dac/blob/master/util/ncFtp2ngdac.pl)

 For automating uploads of [conforming](ngdac-netcdf-file-format-version-2.html) NetCDF files to the DAC ftp server.  The script is written in Perl and requires the following non-core modules:
    + [Readonly](http://search.cpan.org/~roode/Readonly-1.03/Readonly.pm)


Remove or comment out rows 34 -35

kbailey-noaa · 2023-08-28T21:28:05Z

_docs/useful-links.md

@@ -39,13 +39,13 @@ The following is a list of links for data providers and web applications develop
 ## Submitting Data
 - [**Deployment Registration**](https://gliders.ioos.us/providers)

-This link will redirect you to the GliderDAC providers page. From there you can login and create deployments. See the wiki section on [New Deplyment Registration](/ioosngdac/ngdac-netcdf-file-submission-process.html#new-deployment-registration) for more details.
+This link will redirect you to the GliderDAC providers page. From there you can login and create deployments. See the wiki section on [New Deplyment Registration](/glider-dac/ngdac-netcdf-file-submission-process.html#new-deployment-registration) for more details.


We can't point to a separate wiki located elsewhere. Also there's a typo in 'deployment.'
Change the sentence "See the wiki..." to: "See the section on New Deployment Registration for more details.

kbailey-noaa · 2023-08-28T21:30:33Z

nc/template/IOOS_Glider_NetCDF_v3.0-noqartod.cdl

Is this linked somewhere?

There is a "catch-all" link in

glider-dac/_docs/ngdac-netcdf-file-format-version-2.md

Line 65 in eb94b60

**Examples** of the file specification are available as [**NetCDF**](https://github.com/ioos/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.nc), [**CDL**](https://github.com/ioos/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.cdl), and [**ncml**](https://github.com/ioos/ioosngdac/blob/master/nc/template/IOOS_Glider_NetCDF_v2.0.ncml) are available [here](https://github.com/ioos/ioosngdac/tree/master/nc/template).

pointing to the folder. So I guess that we needed all the files in that folder.

kbailey-noaa · 2023-08-28T21:34:47Z

_docs/useful-links.md

Also, change row 55 - Dataset Status
to Dataset Status

ocefpaf force-pushed the fix_links branch from 3156693 to 9f6c118 Compare August 18, 2023 22:21

ocefpaf commented Aug 21, 2023

View reviewed changes

ocefpaf marked this pull request as ready for review August 21, 2023 11:24

ocefpaf requested a review from kbailey-noaa August 21, 2023 11:33

ocefpaf force-pushed the fix_links branch from 147c7c7 to ebdbb89 Compare August 21, 2023 16:45

ocefpaf added 4 commits August 21, 2023 13:47

fix links

e36cad2

fix more links

e89b8d7

use https

95420fe

re-directed to this page

424d5a3

ocefpaf force-pushed the fix_links branch from ebdbb89 to 424d5a3 Compare August 21, 2023 16:47

ocefpaf added 2 commits August 21, 2023 13:49

add GHA

a521882

add pre-commit

d7a486d

ocefpaf force-pushed the fix_links branch from 9d10f1a to dc43462 Compare August 21, 2023 19:48

improve config

b453140

ocefpaf force-pushed the fix_links branch from 90997d6 to b453140 Compare August 21, 2023 20:37

ocefpaf commented Aug 21, 2023

View reviewed changes

_docs/data-workflow.md Outdated Show resolved Hide resolved

ocefpaf added 2 commits August 21, 2023 17:44

replace for GH placeholder

2fa5cc5

remove commented out URL and fix typo

1b41c81

ocefpaf force-pushed the fix_links branch from 1449c1b to 7a8fce7 Compare August 21, 2023 21:14

manual replacement

0a30202

ocefpaf force-pushed the fix_links branch from 7a8fce7 to 0a30202 Compare August 21, 2023 21:17

review actions: remove data-workflow.md

54acf84

kbailey-noaa reviewed Aug 28, 2023

View reviewed changes

_docs/index.md Outdated Show resolved Hide resolved

ocefpaf added 5 commits August 28, 2023 15:07

review actions

0b149fc

add template files

cc7cf01

possibly broken

c851def

Deleted the sentence 'Please read documentation thoroughly...'

f245d8f

use https://community.wmo.int/en/activity-areas/global-telecommunicat…

727f66a

…ion-system-gts

ocefpaf commented Aug 28, 2023

View reviewed changes

remove any mentions to FTP

8be156b

ocefpaf commented Aug 28, 2023

View reviewed changes

kbailey-noaa requested changes Aug 28, 2023

View reviewed changes

ocefpaf added 4 commits August 29, 2023 16:48

fix netCDF link

fa3adf8

remove all commented out code

521da02

unversioned cf conventions

bf2b36d

more review actions

af04697

kbailey-noaa merged commit f59aa4b into ioos:gh-pages Aug 29, 2023

ocefpaf deleted the fix_links branch August 29, 2023 20:39

ocefpaf added a commit to ocefpaf/ioos-metadata that referenced this pull request Mar 28, 2024

port fixes from ioos/glider-dac#259

7a5da54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken links #259

Fix broken links #259

ocefpaf commented Aug 18, 2023 •

edited

Loading

ocefpaf commented Aug 18, 2023 •

edited

Loading

ocefpaf commented Aug 19, 2023 •

edited

Loading

ocefpaf Aug 28, 2023

ocefpaf Aug 28, 2023

kbailey-noaa left a comment

kbailey-noaa Aug 28, 2023

kbailey-noaa Aug 28, 2023

kbailey-noaa Aug 28, 2023

kbailey-noaa Aug 28, 2023

kbailey-noaa Aug 28, 2023

ocefpaf Aug 29, 2023

kbailey-noaa Aug 28, 2023

		@@ -29,42 +29,36 @@ The following is a list of links for data providers and web applications develop

		The IOOS Compliance Checker is a python based tool for data providers to check for completeness and community standard compliance of local or remote netCDF files against metadata standards. This web based tool can be used to check your GliderDAC netCDF files for compliance. Be sure to select GliderDAC in the list of available tests to run.

		- [FTP script](https://github.com/ioos/glider-dac/blob/master/util/ncFtp2ngdac.pl)

Fix broken links #259

Fix broken links #259

Conversation

ocefpaf commented Aug 18, 2023 • edited Loading

ocefpaf commented Aug 18, 2023 • edited Loading

ocefpaf commented Aug 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbailey-noaa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Aug 18, 2023 •

edited

Loading

ocefpaf commented Aug 18, 2023 •

edited

Loading

ocefpaf commented Aug 19, 2023 •

edited

Loading