-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pre-commits #212
add pre-commits #212
Conversation
We need to enable pre-commit-ci first. I don't have my GH key with me now to do it. @MathewBiddle I'll do this later today but if you want to give it a go you can navigate to https://results.pre-commit.ci/ and add this repo to the list of the ones we run pre-commit-ci. BTW, the last two commits are thanks to running these pre-commits. You will probably find the link checker quite useful in other non-sphinx IOOS sites. - repo: https://github.com/tcort/markdown-link-check
rev: v3.11.2
hooks:
- id: markdown-link-check
args: [-q] |
Looks like the link checker is not working on pre-commit-ci :-/ |
Do I need to enable something? I never looked into it yesterday. |
Nope. I did it this morning. BTW, this is the report on the gh-pages:
I'll try to fix a few buy going forward it would be nice to fix the pre-commit-ci. I'm in contact with upstream to figure this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment on the GHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good
Just codespell, that will be useful in the gh-pages, large files, and link check.
Closes #256