Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev take 2 #58

Closed
wants to merge 2 commits into from
Closed

Dev take 2 #58

wants to merge 2 commits into from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 23, 2024

Alternative for #55 and #51.

@ocefpaf ocefpaf marked this pull request as ready for review May 23, 2024 11:31
cc_plugin_glider/util.py Outdated Show resolved Hide resolved
@@ -31,7 +31,9 @@ class GliderCheck(BaseNCCheck):
_cc_display_headers = {3: "Required", 2: "Recommended", 1: "Suggested"}
acceptable_platform_types = {"Seaglider", "Spray Glider", "Slocum Glider"}

def __init__(self):
def __init__(self, options=None):
# Pass through testing options for gliderdac
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @jr3cermak

Suggested change
# Pass through testing options for gliderdac
"""
Takes a list of optional arguments.
"""
# Pass through testing options for gliderdac

@ocefpaf
Copy link
Member Author

ocefpaf commented May 23, 2024

Closing in favor of #61.

@ocefpaf ocefpaf closed this May 23, 2024
@ocefpaf ocefpaf deleted the dev_take_2 branch May 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants