Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #55

Closed
wants to merge 4 commits into from
Closed

Dev #55

wants to merge 4 commits into from

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 23, 2024

@jcermauwedu I'd prefer to send these changes to your PR 51 but it seems I cannot edit you commits. Maybe you need to check the box in:

Screenshot from 2024-05-23 10-46-19

I removed as much lint as I could so we can review your new additions. more clearly. I also preserved all your original commits here. Happy to close this an fix #51 if you prefer.

jr3cermak and others added 4 commits May 23, 2024 10:54
 * ruff linter warning
 * restructure strings based on ruff suggestions
 * Revert some prior glider fixes
@@ -31,7 +31,9 @@ class GliderCheck(BaseNCCheck):
_cc_display_headers = {3: "Required", 2: "Recommended", 1: "Suggested"}
acceptable_platform_types = {"Seaglider", "Spray Glider", "Slocum Glider"}

def __init__(self):
def __init__(self, options=None):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jr3cermak do you want a generic options kw or should we name this skip_variables? I may not be understanding what you want to do but it seems that it is the latter, right?

@jcermauwedu
Copy link

I want the variables to be checked for other requirements - so we cannot necessarily just skip whole variables. At this point, we have datasets that do not contain QARTOD flagging. The tests flag that ancillary_variables attribute as missing. That was the intent to allow the dictionary of options through to catch various flags. Skipping the QC checks only did certain things if I recall. This will be something to follow up on today.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 23, 2024

That was the intent to allow the dictionary of options through to catch various flags. Skipping the QC checks only did certain things if I recall. This will be something to follow up on today.

Got it. Thanks! If we can have an idea of these various flags and write up some docs I believe we can finish this one today.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 23, 2024

Closing this b/c I cannot update it. Somehow using gh repo checkout broke my workflow.

@ocefpaf ocefpaf closed this May 23, 2024
@ocefpaf ocefpaf deleted the dev branch May 23, 2024 11:17
@ocefpaf ocefpaf mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants