-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #55
Dev #55
Conversation
@@ -31,7 +31,9 @@ class GliderCheck(BaseNCCheck): | |||
_cc_display_headers = {3: "Required", 2: "Recommended", 1: "Suggested"} | |||
acceptable_platform_types = {"Seaglider", "Spray Glider", "Slocum Glider"} | |||
|
|||
def __init__(self): | |||
def __init__(self, options=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jr3cermak do you want a generic options
kw or should we name this skip_variables
? I may not be understanding what you want to do but it seems that it is the latter, right?
I want the variables to be checked for other requirements - so we cannot necessarily just skip whole variables. At this point, we have datasets that do not contain QARTOD flagging. The tests flag that |
Got it. Thanks! If we can have an idea of these various flags and write up some docs I believe we can finish this one today. |
Closing this b/c I cannot update it. Somehow using gh repo checkout broke my workflow. |
@jcermauwedu I'd prefer to send these changes to your PR 51 but it seems I cannot edit you commits. Maybe you need to check the box in:
I removed as much lint as I could so we can review your new additions. more clearly. I also preserved all your original commits here. Happy to close this an fix #51 if you prefer.