Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

IL merge Newtonsoft and minor output handling fix #9

Merged
merged 5 commits into from
Jun 17, 2016

Conversation

tpetricek
Copy link
Member

If we do not IL merge Newtonsoft.Json.dll, then Vagabond (MBrace) breaks :-(

The issue was that Newtonsoft.Json.dll gets loaded from two different places (one that comes with FsInteractiveService and another that comes with FsLab, and Vagabond cannot resolve which one to use). Since this is exe, I think this is acceptable solution, though I'm not particularly happy with it.

@tpetricek
Copy link
Member Author

Do not merge yet, looks like we'll need the same thing for Suave.dll

@tpetricek
Copy link
Member Author

I like this even less than before, but ILRepack generates two FSharp.Core.dll references for different versions of it when I added Suave, so instead, this is using the same strategy as in: fsprojects/FAKE#1097. We create our private FsInteractiveService.Suave.dll, that does not clash with the normal one.

This is all ugly as hell, but I can finally run MBrace properly ☁️ ⛅ ☁️

@tpetricek
Copy link
Member Author

Adding bug fix for an issue reported by @evelinag from NDC workshop. The PR #3 broke fsi.AddPrinter, which should now be fixed.

@tpetricek tpetricek mentioned this pull request Jun 17, 2016
@tpetricek tpetricek merged commit 1868abb into ionide:master Jun 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant