Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Rename FCS to avoid clashes (for #1096) #1097

Merged
merged 5 commits into from
Jan 22, 2016

Conversation

tpetricek
Copy link
Member

This implements the solution (3) for #1096

@tpetricek
Copy link
Member Author

I added test script, which checks that another version of FCS can be loaded, but that's not actually run anywhere yet - so if we want to do this change, I'll need to turn this into a proper test first :)

@forki
Copy link
Member

forki commented Jan 21, 2016

'packages\Mono.Cecil\lib\net45\Mono.Cecil.dll' missing

Seems you forgot to commit the deps and lock file

@tpetricek
Copy link
Member Author

I fixed the paths and Travis now reports one failure (still working on AppVeyor):

when running script
» tracing functions should work (FAIL)

Do you have any hints on what this might mean?

Is there some easy way of running the FAKE tests with a debugger attached?

@matthid
Copy link
Member

matthid commented Jan 21, 2016

Is there some easy way of running the FAKE tests with a debugger attached?

Visual Studio works for me :)

Do you have any hints on what this might mean?

Error is here https://travis-ci.org/fsharp/FAKE/builds/103908100#L2181
Test is here: https://github.com/fsharp/FAKE/blob/master/src/test/Test.FAKECore/FSIHelperSpecs.cs#L214

But no I have no idea whats going on

@matthid
Copy link
Member

matthid commented Jan 21, 2016

It looks like FCS is searching for itself somehow? The script in the test is simply referencing FakeLib.dll and calling traceFAKE

@tpetricek
Copy link
Member Author

As far as I can see:

  • I don't get the test failure on Windows machine with older F# Compiler Service
  • Everything seems to pass on both CIs when using newer FCS

I tried searching F.C.S source code for places where it might try to reference itself using assembly name, but did not find anything. Though if we can get confirmation from @dsyme, that would help :)

@forki
Copy link
Member

forki commented Jan 22, 2016

Let's try to build a new alpha

forki added a commit that referenced this pull request Jan 22, 2016
[Experimental] Rename FCS to avoid clashes (for #1096)
@forki forki merged commit 262053b into fsprojects:master Jan 22, 2016
@forki
Copy link
Member

forki commented Jan 22, 2016

I take that back. release failed because missing Fake.FSharp.Compiler.Service.dll.XML during docs build in FSharp.Formmating ;-)

@forki
Copy link
Member

forki commented Jan 22, 2016

ok fixed that. let's see

@forki
Copy link
Member

forki commented Jan 22, 2016

oK release succeeded. let's start dogfooding in FAKE and Paket.

@forki
Copy link
Member

forki commented Jan 22, 2016

ok seems to work in Paket and FAKE itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants