fix(nav): swipe to go back gesture #8951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
improved-go-back-swipe
branch
9 times, most recently
from
ad24b79 to
02d5a28
Compare
- smoother by debouncing touch events (reduces bank) - dynamic animation duration - intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item) fixes ionic-team#8919 fixes ionic-team#8958 fixes ionic-team#7934
manucorporat
force-pushed
the
improved-go-back-swipe
branch
from
02d5a28 to
1af6de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Changes proposed in this pull request:
Also, this PR features a very interesting performance improvement that soon could by applied to the sidemenu, reorder, sliding item... very promising!!
BEFORE:
AFTER:
fixes #8919
fixes #8958
fixes #7934