Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Cannot swipe to go back on iOS with tabs and tabsHideOnSubPages true #7934

Closed
apparition47 opened this issue Aug 31, 2016 · 4 comments · Fixed by #8951
Closed

[v2] Cannot swipe to go back on iOS with tabs and tabsHideOnSubPages true #7934

apparition47 opened this issue Aug 31, 2016 · 4 comments · Fixed by #8951
Assignees
Milestone

Comments

@apparition47
Copy link

apparition47 commented Aug 31, 2016

Short description of the problem:

Cannot swipe to go back on iOS with tabs and tabsHideOnSubPages: true on 2.0.0-beta.11.

What behavior are you expecting?

When pushing pages onto the navigation stack with tabs on iOS, doing the swipe to go back gesture doesn't pop the navigation stack when tabsHideOnSubPages: true.

Steps to reproduce:

  1. Set a tabs template as rootPage.
  2. Push another page
  3. [iOS] Swipe back gesture to pop nav. Doesn't work unless I change tabsHideOnSubPages: false.
@Component({
    template: '<ion-nav [root]="rootPage"></ion-nav>'
})
export class MyApp {
    static get parameters() {
        return [..];
    }

    constructor(..) {
        this.rootPage = TabsPage;
    }
}
ionicBootstrap(
    MyApp,
    [...],
    {
        tabsHideOnSubPages: true,
        prodMode: true
    }
);
<ion-tabs primary selectedIndex="0">
  <ion-tab [root]="tab1Root" tabTitle="C" tabIcon="more"></ion-tab>
  <ion-tab [root]="tab2Root" tabTitle="M" tabIcon="more"></ion-tab>
  <ion-tab [root]="tab3Root" tabTitle="C" tabIcon="more"></ion-tab>
  <ion-tab [root]="tab4Root" tabTitle="A" tabIcon="more"></ion-tab>
</ion-tabs>
<ion-header>
    <ion-navbar primary>
        <ion-title>
            A
        </ion-title>
    </ion-navbar>
</ion-header>

<ion-content>
    <button ion-button block outline secondary [navPush]="SPage">
</ion-content>

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

Which Ionic Version? 2.x

Plunker that shows an example of your issue

I created a plunkr however you need to test in a app environment on iOS.
http://plnkr.co/edit/SLY1b5qTDwJErnSIuMHQ

Run ionic info from terminal/cmd prompt: (paste output below)

Your system information:

Cordova CLI: 6.3.0
Gulp version:  CLI version 3.8.11
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11-201608162233
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.5.0 
ios-sim version: 3.1.1 
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3 Build version 7D175 

Note:
iPhone 6 Plus iOS 9.3.5
WKWebView

@apparition47 apparition47 changed the title [v2] Cannot swipe to go back on iOS with tabs and tabsHideOnSubPages false [v2] Cannot swipe to go back on iOS with tabs and tabsHideOnSubPages true Aug 31, 2016
@jgw96 jgw96 added v2 and removed header labels Sep 1, 2016
@apparition47
Copy link
Author

I'm still seeing the same behaviour on 2.0.0-rc.0 with the following and tabs

app.module.ts

@NgModule({
    declarations: components,
    imports: [
        IonicModule.forRoot(MyApp, {tabsHideOnSubPages: true})
    ],
    bootstrap: [IonicApp],
    entryComponents: components,
    providers: [
        // ...
    ]
})

@triasrahman
Copy link

I have same issue

@gxsjtu
Copy link

gxsjtu commented Oct 17, 2016

same issue

@manucorporat
Copy link
Contributor

Working in a fix, looks like it is more complicated than expected...

manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 31, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 31, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes ionic-team#8919
fixes ionic-team#8958
fixes ionic-team#7934
adamdbradley pushed a commit that referenced this issue Nov 1, 2016
- smoother by debouncing touch events (reduces bank)
- dynamic animation duration
- intelligent behavior based in the position, speed and direccion of the swipe (sharing logic with sliding item)

fixes #8919
fixes #8958
fixes #7934
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants