fix(vue): add optional IonicConfig type parameter to IonicVue plugin #29637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any update on this PR ? |
|
@Sukaato Thank you for the PR! Is this PR associated to an open issue? If it is, please add the issue number. If it's not, please open a new issue that highlights the reason why this PR is needed. |
|
here's the issue: #29659 |
|
@thetaPC a really useful little improvement
|
thetaPC
changed the title
thetaPC
changed the title
3 tasks
brandyscarney
changed the title
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In v3.2.46 [vue was updated](vuejs/core#3969) to add support for a generic type argument to the `Plugin` type. In #29637 Ionic's Vue plugin was updated to use the generic, but the`@ionic/vue` project is currently installing v3.2.37. This results in a local type checking error and build error: ``` (!) Plugin typescript: @rollup/plugin-typescript TS2315: Type 'Plugin_2' is not generic. src/ionic-vue.ts: (24:24) 24 export const IonicVue: Plugin<[IonicConfig?]> = { ``` ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Bumps and pins the dev dependency of `vue` to `3.2.46`. There are other breaking changes that Vue has shipped in minor/patch cycles that prevents from updating to the latest. - Resolves the type checking error locally during build of the`@ionic/vue` package ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Validation steps: 1. Checkout the branch 2. Build `core/` 3. In `packages/vue`, install latest pinned dependencies with `npm ci` 4. Sync the changes to the `vue` package with `npm run sync` 5. Open `/packages/vue/src/ionic-vue.ts` 6. Observe: No type errors on L24 7. Run `npm run build` 8. Observe: No build errors
This was referenced Aug 25, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29659
What is the current behavior?
while using
.use(IonicVue, {}), the config object has no autocomplete.What is the new behavior?
Does this introduce a breaking change?
Other information