Skip to content

Commit

Permalink
feat(vue): add optional IonicConfig type parameter to IonicVue plugin (
Browse files Browse the repository at this point in the history
…#29637)

Issue number: #29659

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
while using `.use(IonicVue, {})`, the config object has no autocomplete.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- Add type autocomplete on plugin option in VueJS package.


## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Co-authored-by: Julien Vaumoron <[email protected]>
  • Loading branch information
Sukaato and Julien Vaumoron authored Jun 28, 2024
1 parent 4eb1629 commit 90893f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/vue/src/ionic-vue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const getHelperFunctions = () => {
};
};

export const IonicVue: Plugin = {
export const IonicVue: Plugin<[IonicConfig?]> = {
async install(_: App, config: IonicConfig = {}) {
/**
* By default Ionic Framework hides elements that
Expand Down

0 comments on commit 90893f4

Please sign in to comment.