Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): nav component accepts kebab-case component properties #28615

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix(vue): nav component accepts kebab-case component properties #28615

merged 3 commits into from
Dec 1, 2023

Conversation

Ericlm
Copy link
Contributor

@Ericlm Ericlm commented Nov 30, 2023 •
edited by liamdebeasi
Loading

Issue number: resolves #28611

What is the current behavior?

It's not possible to pass props that are not camelCase to the IonNav component.

What is the new behavior?

  • It is now possible to set a props with kebab-case instead of camelCase (for example, root-params instead of rootParams)

Does this introduce a breaking change?

  • Yes
  • No

Other information

⚠️ This is my first PR for ionic so I hope I didn't miss important steps into the process. I also checked on my project that the fix is working well. Thank you! 🙂

@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 30, 2023
@sean-perkins sean-perkins changed the title fix(nav): adds component props to allow kebab-case fix(vue): nav component accepts kebab-case component properties Nov 30, 2023
@sean-perkins sean-perkins self-requested a review November 30, 2023 21:29
sean-perkins
sean-perkins approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for your contribution!

liamdebeasi
liamdebeasi approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified fix using dev build 7.5.8-dev.11701374238.101cd738. Thanks for contributing this fix!

@liamdebeasi liamdebeasi added this pull request to the merge queue Dec 1, 2023
Merged via the queue into ionic-team:main with commit 60303aa Dec 1, 2023
46 checks passed
@liamdebeasi liamdebeasi mentioned this pull request Dec 1, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-perkins sean-perkins sean-perkins approved these changes

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@thetaPC thetaPC Awaiting requested review from thetaPC

Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: RootParams of ion-nav not detected if in kebab-case
3 participants
@Ericlm @liamdebeasi @sean-perkins