-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(vue): nav component accepts kebab-case component properties (#28615)
Issue number: resolves #28611 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> It's not possible to pass props that are not camelCase to the `IonNav` component. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - It is now possible to set a props with kebab-case instead of camelCase (for example, `root-params` instead of `rootParams`) ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->⚠️ This is my first PR for ionic so I hope I didn't miss important steps into the process. I also checked on my project that the fix is working well. Thank you! 🙂 --------- Co-authored-by: Sean Perkins <[email protected]>
- Loading branch information
1 parent
a3cd204
commit 60303aa
Showing
4 changed files
with
66 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,12 @@ | ||
<template> | ||
<ion-nav :root="NavRoot"></ion-nav> | ||
<ion-nav :root="NavRoot" :root-params="rootParams"></ion-nav> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineComponent } from 'vue'; | ||
import { IonNav } from '@ionic/vue'; | ||
import NavRoot from '@/components/NavRoot.vue'; | ||
<script setup lang="ts"> | ||
import { IonNav } from "@ionic/vue"; | ||
import NavRoot from "@/components/NavRoot.vue"; | ||
export default defineComponent({ | ||
components: { IonNav }, | ||
setup() { | ||
return { NavRoot } | ||
} | ||
}); | ||
const rootParams = { | ||
message: "Hello World!", | ||
}; | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters