Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(alert): add annotations #28414

Merged
merged 1 commit into from
Oct 25, 2023
Merged

test(alert): add annotations #28414

merged 1 commit into from
Oct 25, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 25, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

I forgot to add annotations to tests to indicate the bug fix they are validating: #28408

What is the new behavior?

  • Added annotations

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi
test(alert): add annotations
772d279 
I forgot to add annotations to tests to indicate the bug fix they are validating.
@liamdebeasi liamdebeasi requested a review from thetaPC October 25, 2023 17:31
@github-actions github-actions bot added the package: core @ionic/core package label Oct 25, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review October 25, 2023 17:32
@liamdebeasi liamdebeasi enabled auto-merge October 25, 2023 18:48
thetaPC
thetaPC approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit dc94ae0 Oct 25, 2023
45 checks passed
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-1 branch October 25, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @thetaPC