fix(alert): long words wrap to next line #28408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
approved these changes
Oct 25, 2023
thetaPC
approved these changes
Oct 25, 2023
| @@ -28,6 +28,59 @@ const testAria = async ( | |||
| expect(ariaDescribedBy).toBe(expectedAriaDescribedBy); | |||
| }; | |||
|
|
|||
| configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | |||
There was a problem hiding this comment.
Not to sound like a broken record but adding an annotation for the issue would be great.
There was a problem hiding this comment.
Sorry! I'll add this.
This was referenced Oct 25, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> I forgot to add annotations to tests to indicate the bug fix they are validating: #28408 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Added annotations ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28406
What is the current behavior?
As part of #27898 we updated the radio and checkbox labels to wrap to the next line instead of truncate. However, we did not consider long words. As a result, long words run outside of the container.
What is the new behavior?
Does this introduce a breaking change?
Other information