Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): swipe to close modal is no longer swipeable on footer #23401

Merged
merged 2 commits into from
Jun 2, 2021
Merged

fix(modal): swipe to close modal is no longer swipeable on footer #23401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd65ffb
fix(modal): Swipe to close modal is not swipeable on the footer anymore
EinfachHans Jun 2, 2021
da00650
Update core/src/components/modal/gestures/swipe-to-close.ts
liamdebeasi Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/components/modal/gestures/swipe-to-close.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ export const createSwipeToCloseGesture = (
return true;
}

const content = target.closest('ion-content');
if (content === null) {
const contentOrFooter = target.closest('ion-content, ion-footer');
if (contentOrFooter === null) {
return true;
}
// Target is in the content so we don't start the gesture.
// Target is in the content or the footer so do not start the gesture.
// We could be more nuanced here and allow it for content that
// does not need to scroll.
return false;
Expand Down