Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): swipe to close modal is no longer swipeable on footer #23401

Merged
merged 2 commits into from
Jun 2, 2021
Merged

fix(modal): swipe to close modal is no longer swipeable on footer #23401

merged 2 commits into from
Jun 2, 2021

Conversation

EinfachHans
Copy link
Contributor

closes #23398

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

An iOS Card Style Modal is currently able to swipe down on the Footer.

Issue Number: #23398

What is the new behavior?

  • According to @liamdebeasi 's comments in my issue i edited the code to make the gesture not be start-able on the footer as well

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title fix(modal): Swipe to close modal is not swipeable on the footer anymore fix(modal): swipe to close modal is no longer swipeable on footer Jun 2, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I tested and this is working as expected now.

core/src/components/modal/gestures/swipe-to-close.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the package: core @ionic/core package label Jun 2, 2021
@liamdebeasi liamdebeasi merged commit ae96563 into ionic-team:master Jun 2, 2021
@liamdebeasi
Copy link
Contributor

Merged. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: swipe to close modal should not be swipeable on the footer
2 participants