fix(core): inherit aria attributes on host elements #25156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
approved these changes
Apr 20, 2022
liamdebeasi
approved these changes
Apr 20, 2022
averyjohnston
approved these changes
Apr 21, 2022
sean-perkins
added a commit
that referenced
this pull request
Apr 21, 2022
13 tasks
liamdebeasi
pushed a commit
that referenced
this pull request
Apr 27, 2022
This was referenced May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ARIA attributes specified on the host element are not reflected to the cloned element in the light DOM. For example, with
ion-buttonwe create abuttonand clone it into the light DOM so that screen readers can correctly interact with the element. Currently, we are only supportingaria-labelto be reflected to the HTMLbutton.Issue URL: Enterprise FW-1138, Enterprise FW-1071, #20127
What is the new behavior?
All WAI-ARIA attributes, as listed here are reflected to the following components:
ion-buttonion-back-buttonion-breadcrumbion-headerion-inpution-textareaion-menuion-menu-buttonDoes this introduce a breaking change?
Other information
I opted for a manually managed list of aria attributes over regular expression matching, after taking into consideration the execution cost of regex for each web component instance + the number of attributes/properties on an element.
This approach should be easily applicable to other open issues, to add support for aria attributes.