Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inherit aria attributes of ion-fab-button #25633

Closed
sebastian-student opened this issue Jul 14, 2022 · 2 comments · Fixed by #25635
Closed

bug: inherit aria attributes of ion-fab-button #25633

sebastian-student opened this issue Jul 14, 2022 · 2 comments · Fixed by #25635
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@sebastian-student
Copy link

sebastian-student commented Jul 14, 2022

Ionic version:
[] 4.x
[] 5.x
[x] 6.x

I'm submitting a ...
[x] bug report
[ ] feature request

Current behavior:
Adding an aria-label to an ion-fab-button with [attr.aria-label] the label is not inherited to the contained button.

Expected behavior:
Inherit aria attributes like on ion-button

Related code:

<ion-button [attr.aria-label]="'aria.example-label' | translate"></ion-button> <!-- is inherited -->
<ion-fab-button [attr.aria-label]="'aria.example-label' | translate"></ion-fab-button> <!-- is not inherited -->

Other information:
Similar issue already existed for other buttons but ion-fab-button wasn't included in #25156

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/Users/sebastian/node_modules/ionic)
   Ionic Framework               : @ionic/angular 6.1.11
   @angular-devkit/build-angular : 13.2.6
   @angular-devkit/schematics    : 13.3.8
   @angular/cli                  : 13.2.6
   @ionic/angular-toolkit        : 6.1.0

Cordova:

   cordova (Cordova CLI) : 10.0.0
   Cordova Platforms     : ios 6.2.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.2.0, (and 30 other plugins)

System:

   Android SDK Tools : 26.1.1 (/Users/sebastian/Library/Android/sdk)
   ios-deploy        : 1.11.4
   ios-sim           : 8.0.2
   NodeJS            : v14.18.2 (/Users/sebastian/.nvm/versions/node/v14.18.2/bin/node)
   npm               : 6.14.15
   OS                : macOS Monterey
   Xcode             : Xcode 13.3 Build version 13E113

@ionitron-bot ionitron-bot bot added the triage label Jul 14, 2022
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Jul 14, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jul 14, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #25635, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 13, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants