Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): inherit aria attributes on host elements (#25156) #25169

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Apr 21, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Most ARIA attributes are not reflected to the light DOM.

Issue URL: Enterprise

What is the new behavior?

Back ports the solution for #25156 to 5.9.x.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Apr 21, 2022
@liamdebeasi liamdebeasi merged commit ffb056d into 5.9.x Apr 27, 2022
@liamdebeasi liamdebeasi deleted the fix/inherit-aria-attributes branch April 27, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants