feat(android/Bridge): allow custom ssl certs in dev #2271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but we don't want to disable SSL checks, not even for dev builds because it's insecure and having different behaviors in dev and release modes have caused a lot of problems to Cordova users in the past and we don't want to repeat the same mistakes. We have few issues and PRs with different possibilities of what could be done to allow users or plugins to change the WebViewClient's behavior such as #2230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will set the webview to ignore ssl certificate errors in development. This will allow people to use https localhost servers with a self signed certificate.