Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide WebViewClient accessor on bridge #2230

Closed
jcesarmobile opened this issue Dec 7, 2019 · 2 comments · Fixed by #2477
Closed

feat: provide WebViewClient accessor on bridge #2230

jcesarmobile opened this issue Dec 7, 2019 · 2 comments · Fixed by #2477
Labels
enhancement priority: high
Milestone
2.0.0

Comments

@jcesarmobile
Copy link
Member

jcesarmobile commented Dec 7, 2019 •
edited
Loading

Some plugins or scripts might want to modify or augment the WebViewClient.

Android webView has a getWebViewClient method, but requires API 26.

Would be good if the bridge could provide a getWebViewClient method itself that returns the WebViewClient being set by Capacitor.

Also we should use a WebViewClient subclass that can be subclassed to make it easier to override unimplemented methods (or the implemented ones if needed).
@jcesarmobile jcesarmobile added the needs discussion decisions must be made before working on it label Jan 23, 2020
@jcesarmobile jcesarmobile added this to the 2.0.0 milestone Jan 29, 2020
This was referenced Jan 31, 2020
Closed
Closed
@jcesarmobile jcesarmobile removed the needs discussion decisions must be made before working on it label Feb 24, 2020
@jcesarmobile jcesarmobile mentioned this issue Feb 24, 2020
Merged
@cepages
Copy link

cepages commented Mar 13, 2020

@jcesarmobile is there any documentation that helps me to use this feature? Thanks

@nklayman nklayman mentioned this issue Apr 11, 2020
Closed
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement priority: high
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat(android): provide WebViewClient accessor jcesarmobile/capacitor
2 participants
@jcesarmobile @cepages