Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): enable full screen video #1763

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Conversation

rgolea
Copy link
Contributor

@rgolea rgolea commented Jul 15, 2019

This allows capacitor to handle fullscreen. This is my first attempt to write code in Java and please keep in mind it's a really strange environment for me.

Thanks

This should close #605

This allows capacitor to handle fullscreen
Forgot import
@rgolea rgolea changed the title Allow requestFullscreen on videos Allow full screen video on Android Jul 15, 2019
@jcesarmobile jcesarmobile changed the title Allow full screen video on Android fix(android): enable full screen video Jul 17, 2019
@jcesarmobile jcesarmobile merged commit 2b38032 into ionic-team:master Jul 17, 2019
@rgolea
Copy link
Contributor Author

rgolea commented Jul 17, 2019

Thank you @jcesarmobile!

@black-hawk85
Copy link

I am working with capacitor plugin (nice work by the way) and using vue-fullscreen.
Since v1.1.1 it is working for Android but iOS is not turing into fullscreen mode.
Can this problem be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow full screen video on Android
3 participants