Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full screen video on Android #605

Closed
jcesarmobile opened this issue Jun 23, 2018 · 4 comments · Fixed by #1763
Closed

Allow full screen video on Android #605

jcesarmobile opened this issue Jun 23, 2018 · 4 comments · Fixed by #1763

Comments

@jcesarmobile
Copy link
Member

jcesarmobile commented Jun 23, 2018

I've created a video.js sample app and it doesn't show the full screen video button, nor opens full screen when using playsinline: false option.
Same app in Cordova has full screen video button and goes full screen when play is pressed if playsinline: false option is used.
We should also allow full screen video in Capacitor

Sample app:
https://github.com/jcesarmobile/playerjs-example

@greensopinion
Copy link

We've run into this issue as well, the "full screen" control button is present but disabled on the video player.

@rgolea
Copy link
Contributor

rgolea commented Jul 15, 2019

@greensopinion try PR #1763 and tell me if this works for you

@greensopinion
Copy link

@greensopinion try PR #1763 and tell me if this works for you

Just tested on the simulator, works! Thanks @rgolea

@rgolea
Copy link
Contributor

rgolea commented Jul 16, 2019

@greensopinion any time! I would recommend that each time you start a project you just copy-paste the changes from the PR in order to have the latest version of capacitor (until the PR merges).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants