Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dc/eslint #350

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Dc/eslint #350

merged 1 commit into from
Sep 3, 2021

Conversation

dcavanagh
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dcavanagh dcavanagh added the chore label Sep 1, 2021
@PodaruDragos
Copy link
Contributor

this is really cool. can we maybe merge this #344 before ? Then we are really good to go here.

nice work.

@dcavanagh dcavanagh marked this pull request as ready for review September 1, 2021 12:07
leonardssh
leonardssh approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@leonardssh leonardssh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcavanagh dcavanagh force-pushed the dc/eslint branch 2 times, most recently from d1e42af to 5864838 Compare September 2, 2021 12:49
@dcavanagh dcavanagh merged commit d09dfbb into master Sep 3, 2021
@dcavanagh dcavanagh deleted the dc/eslint branch September 3, 2021 12:49
@dcavanagh dcavanagh mentioned this pull request Sep 3, 2021
Closed
@guidojw guidojw mentioned this pull request Oct 15, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardssh leonardssh leonardssh approved these changes

@notaphplover notaphplover Awaiting requested review from notaphplover

@PodaruDragos PodaruDragos Awaiting requested review from PodaruDragos

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcavanagh @PodaruDragos @leonardssh