Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript compiler #344

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Update typescript compiler #344

merged 4 commits into from
Sep 1, 2021

Conversation

PodaruDragos
Copy link
Contributor

@PodaruDragos PodaruDragos commented May 7, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

notaphplover
notaphplover requested changes May 8, 2021
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes should be accomplished. Sry for the late review

tsconfig.json Outdated Show resolved Hide resolved
src/base_http_controller.ts Show resolved Hide resolved
src/content/jsonContent.ts Outdated Show resolved Hide resolved
src/content/stringContent.ts Outdated Show resolved Hide resolved
src/debug.ts Outdated Show resolved Hide resolved
src/decorators.ts Show resolved Hide resolved
src/interfaces.ts
@@ -14,7 +14,7 @@ namespace interfaces {
}

export interface ControllerMethodMetadata extends ControllerMetadata {
method: string;
method: keyof typeof HTTP_VERBS_ENUM;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be using values (HTTP_VERBS_ENUM)

@notaphplover notaphplover self-requested a review August 23, 2021 20:47
This was referenced Aug 25, 2021
Merged
Merged
@dcavanagh dcavanagh merged commit 2462cd2 into inversify:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcavanagh dcavanagh Awaiting requested review from dcavanagh

@notaphplover notaphplover Awaiting requested review from notaphplover

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PodaruDragos @notaphplover @dcavanagh