[BLOCKED] Replace cchardet with faust-cchardet
#175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
max-moser
commented
May 11, 2023
max-moser
commented
- the original package hasn't received updates since 2021, while the latter is still active
- cchardet also doesn't play nice with python 3.10 and 3.11
max-moser
force-pushed
the
mm/faust-chardet
branch
from
9a2b09e to
1246460
Compare
tmorrell
reviewed
May 25, 2023
There was a problem hiding this comment.
Looks like there might be an issue with M1 support faust-streaming/cChardet#12
* the original package hasn't received updates since 2021, while the latter is still active * cchardet also doesn't play nice with python 3.10 and 3.11
ntarocco
force-pushed
the
mm/faust-chardet
branch
from
1246460 to
b3c4780
Compare
ntarocco
approved these changes
Sep 11, 2023
ntarocco
changed the title
cchardet with faust-cchardetcchardet with faust-cchardet
|
Superseded by #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.