Merge pull request #38 from invenia/ox/strides

Add Strided Array Interface
invenia · Feb 25, 2020 · ecd00f0 · ecd00f0 · oxinabox · Feb 25, 2020
2 parents 465a01c + be2fae1
commit ecd00f0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "NamedDims"
 uuid = "356022a1-0364-5f58-8944-0da4b18d706f"
 authors = ["Invenia Technical Computing Corporation"]
-version = "0.2.16"
+version = "0.2.17"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/wrapper_array.jl b/src/wrapper_array.jl
@@ -106,6 +106,13 @@ function Base.similar(
     return similar(a, eltype, dims)
 end
 
+#####################################
+# Strided Array interface
+Base.stride(a::NamedDimsArray, k::Symbol) = stride(parent(a), dim(a, k))
+Base.stride(a::NamedDimsArray, k::Integer) = stride(parent(a), k)
+Base.strides(a::NamedDimsArray) = strides(parent(a))
+
+
 ###############################
 # kwargs indexing
 

diff --git a/test/wrapper_array.jl b/test/wrapper_array.jl
@@ -147,6 +147,12 @@ end
     end
 end
 
+@testset "Strided Array Interface" begin
+    x = ones(3, 5)
+    nda = NamedDimsArray{(:a, :b)}(x)
+    @test strides(nda) == (1, 3) == strides(x)
+    @test stride(nda, :b) == 3 == stride(nda, 2) == stride(x, 2)
+end
 
 const cnda = NamedDimsArray([10 20; 30 40], (:x, :y))
 @testset "allocations: wrapper" begin