Add Strided Array Interface #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 89.07% 89.18% +0.11%
==========================================
Files 9 9
Lines 293 296 +3
==========================================
+ Hits 261 264 +3
Misses 32 32
Continue to review full report at Codecov.
|
|
I wanted this again today. |
nickrobinson251
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because right now StridedArray is a Union and thus not extensible
(see JuliaLang/julia#30432)
you don't need to implement
stridesexplictly for all new strided array types,which we can assume (and then be proven wrong with later method errors)
that our wrapped type is.
This is needed for some BLAS stuff called by Distributions.jl