Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fixes prop type warning for MarkdownProvider -> location #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcrosby114
Copy link

@mcrosby114 mcrosby114 commented Oct 4, 2019

What's changing?

Fixes one of the React console errrors (#32).

What else might be impacted?

Checklist

  • Documentation
  • New Tests
  • Added myself to contributors table
  • Added SemVer label
  • Ready to be merged

@mcrosby114 mcrosby114 marked this pull request as ready for review October 4, 2019 18:13
@hipstersmoothie
Copy link
Contributor

Can you fix the tests?

@mcrosby114
Copy link
Author

Can you fix the tests?

Yes I'll circle back and find anther way to address the prop problem. It starts out as undefined and then gets an object set.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files          47       47           
  Lines         997      997           
  Branches      139      139           
=======================================
  Hits          845      845           
  Misses        152      152
Impacted Files Coverage Δ
src/app/components/MarkdownProvider/index.js 100% <ø> (ø) ⬆️
src/app/components/Router/get-location.js 100% <ø> (ø) ⬆️
src/loaders/html-to-react.js 94.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5b50d...b056895. Read the comment docs.

@mcrosby114 mcrosby114 changed the title Fixes prop type warning for location being undefined Fixes prop type warning for MarkdownProvider -> location Oct 11, 2019
@mcrosby114
Copy link
Author

mcrosby114 commented Oct 11, 2019

Hmm not sure why the test attach creation date to each blog post is not outputting a "birth" of 1526623637000 as before. That's the one failing test.

@mcrosby114
Copy link
Author

@hipstersmoothie any idea what might account for this failing test? I'm not seeing the connection between my changes and the test attach creation date to each blog post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants