Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Address react console errors #32

Open
hipstersmoothie opened this issue Jul 4, 2018 · 3 comments
Open

Address react console errors #32

hipstersmoothie opened this issue Jul 4, 2018 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hipstersmoothie
Copy link
Contributor

No description provided.

@hipstersmoothie hipstersmoothie added the bug Something isn't working label Jul 4, 2018
@hipstersmoothie hipstersmoothie added the good first issue Good for newcomers label Nov 13, 2018
@mcrosby114
Copy link

I'll take this if available

@hipstersmoothie
Copy link
Contributor Author

Go for it!

@mcrosby114
Copy link

This was tough, I did my best to fix the console errors I was seeing.

  • Warning: React does not recognize the currentPage prop on a DOM element.
    • This appears to be required for the router to work. The issue is that it is attaching currentpage to <a> elements, which is an unrecognized attribute. Not sure how to get around this since it appears to break the system when removed.
  • Warning: componentWillReceiveProps has been renamed, and is not recommended for use.
    • This is coming from components called ChromeFields, ColorPicker, and EditbableInput. I could not find these in the source code.
  • Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>
    • I saw many of these appear when you click on Included Plugins and Bulma Plugins. It was tough tracking down where the <p> elements are generated and inserted into the DOM. I tried changing this line to source.replace(new RegExp('<p>', 'g'), '<div className="menu-label">'); for example but that broke things.
  • Warning: Received the string truefor the boolean attributechecked. Although this works, it will not work as expected if you pass the string "false". Did you mean checked={true}?
    • Could not find anywhere where the source code is setting a checked prop, so appears to be out of our control, perhaps coming from another library?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants