Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to k8s v1.19.3 #493

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Upgrade to k8s v1.19.3 #493

merged 1 commit into from
Nov 10, 2020

Conversation

rojkov
Copy link
Contributor

@rojkov rojkov commented Nov 4, 2020

Closes #452

bart0sh
bart0sh approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

mythi
mythi reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Lets wait a bit because of: sigs.k8s.io/controller-runtime v0.7.0-alpha.6

@mythi
Copy link
Contributor

mythi commented Nov 5, 2020

I tested SGX webhook and it works. However, I can see leader election permission errors like this:

E1105 09:57:35.558165       1 leaderelection.go:321] error retrieving resource lock inteldeviceplugins-system/d1c7b6d5.intel.com: leases.coordination.k8s.io "d1c7b6d5.intel.com" is forbidden: User "system:serviceaccount:inteldeviceplugins-system:default" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "inteldeviceplugins-system"

bart0sh
bart0sh previously approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@bart0sh bart0sh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tested fpga plugin functionality manually on the machine with 2 Intel Arria10 FPGA devices

@mythi
Copy link
Contributor

mythi commented Nov 10, 2020

@rojkov @bart0sh everything works for SGX and the errors are gone!

perhaps rebase+squash and then let's merge?

@bart0sh
Copy link
Member

bart0sh commented Nov 10, 2020

@mythi sgtm

@rojkov
Copy link
Contributor Author

rojkov commented Nov 10, 2020

Ok, rebased and squashed.

@bart0sh bart0sh merged commit ad02fc4 into intel:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythi mythi mythi left review comments

@bart0sh bart0sh bart0sh approved these changes

@kad kad Awaiting requested review from kad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to k8s 1.19 APIs
3 participants
@rojkov @mythi @bart0sh