Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to k8s 1.19 APIs #452

Closed
mythi opened this issue Sep 11, 2020 · 5 comments · Fixed by #493
Closed

update to k8s 1.19 APIs #452

mythi opened this issue Sep 11, 2020 · 5 comments · Fixed by #493
Assignees

Comments

@mythi
Copy link
Contributor

mythi commented Sep 11, 2020

No description provided.

@rojkov
Copy link
Contributor

rojkov commented Oct 15, 2020

K8s 1.19 has updated dependency on github.com/go-logr/logr to v0.2.0, but the latest released sigs.k8s.io/controller-runtime (0.6.3) still depends on logr v0.1.0.

controller-runtime 0.7.0, which seems to have the dependency updated, hasn't been released yet.

This prevents us from updating to k8s 1.19.

@mythi
Copy link
Contributor Author

mythi commented Oct 16, 2020

controller-runtime 0.7.0, which seems to have the dependency updated, hasn't been released yet.

Let's wait 0.7.0. It looks it's not too far away...

@mythi
Copy link
Contributor Author

mythi commented Nov 2, 2020

controller-runtime 0.7.0, which seems to have the dependency updated, hasn't been released yet.

@rojkov can you start with a draft PR that updates k8s 1.19 and controller-runtime 0.7.0-alpha4. Or would Replace v0.1.0 -> v0.2.0 work?

@rojkov
Copy link
Contributor

rojkov commented Nov 2, 2020

Ok. I'll start with moving to controller-runtime 0.7.0-alpha4. It seems to be a safer bet.

@rojkov
Copy link
Contributor

rojkov commented Nov 2, 2020

Now all deps seem to resolve ok. I pushed the new go.mod to my private release-0.19 branch. The next step is to make the code compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants