Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPR BM for e2e #1699

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Use SPR BM for e2e #1699

merged 1 commit into from
Apr 25, 2024

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Mar 26, 2024

No description provided.

@tkatila tkatila force-pushed the bm-spr-test branch 3 times, most recently from 405352a to 5f5e8cc Compare March 28, 2024 08:51
@tkatila
Copy link
Contributor Author

tkatila commented Mar 28, 2024

Please comment on the structure. In order to run multiple tests per run, I had to move the ginkgo variables out of the workflow. If the variables are for the whole test session, then qat is the only one that passes and dsa and iaa are skipped. This structure is a bit annoying as it ties device plugin project and the bmaas scripts more together. We wouldn't, for example, be able make a patch release for older releases without changing the bmaas side.

The bmaas changes are visible in the bmaas project.

@mythi
Copy link
Contributor

mythi commented Apr 2, 2024

@hj-johannes-lee can you comment?

@mythi
Copy link
Contributor

mythi commented Apr 2, 2024

If the variables are for the whole test session, then qat is the only one that passes and dsa and iaa are skipped.

It's not clear to me what the issue is. I get a pretty comprehensive list with:

go test -v ./test/e2e/... -args -ginkgo.dry-run   -ginkgo.focus "Device:(dsa|iaa|qat|sgx)"

@tkatila
Copy link
Contributor Author

tkatila commented Apr 2, 2024

When I tried to run qat, dsa and iaa e2e tests back to back, only qat executed due to the qat4's ginkgo focus/skip: FOCUS="Mode:dpdk.*Resource:(cy|dc)" SKIP=App:crypto-perf. dsa and iaa were skipped.

It might be possible to create a "e2e-spr" target which would run all the tests with one call. I can look into it.

@mythi
Copy link
Contributor

mythi commented Apr 2, 2024

When I tried to run qat, dsa and iaa e2e tests back to back, only qat executed due to the qat4's ginkgo focus/skip: FOCUS="Mode:dpdk.*Resource:(cy|dc)" SKIP=App:crypto-perf. dsa and iaa were skipped.

It might be possible to create a "e2e-spr" target which would run all the tests with one call. I can look into it.

It's quite likely that the regexp creation is just broken. Moreover, we have #1687 WIP that should help streamline this a bit. That's why I asked @hj-johannes-lee to comment on this

@tkatila tkatila force-pushed the bm-spr-test branch 2 times, most recently from 526e3ad to a0181a5 Compare April 4, 2024 10:52
@hj-johannes-lee
Copy link
Contributor

sorry for being so slow recently.
Let me push a commit that fixes #1687. That would make this more easy..!

@tkatila
Copy link
Contributor Author

tkatila commented Apr 9, 2024

This is the current ginkgo focus: -ginkgo.focus "Device:(iaa|dsa)|Device:qat.*Mode:dpdk.*Resource:(cy|dc).*" -ginkgo.focus "Device:gpu.*Resource:i915"

I think I tried it without Mode and Resource. For Resource it failed due to trying to run generic tests. I can't recall why Mode had issues, but I'm sure it had.

@hj-johannes-lee
Copy link
Contributor

hj-johannes-lee commented Apr 11, 2024

If mode was not used, then yeah, as you said
[Moide:dpdk] [Resource: generic] will be run.
And it is possible that [Mode:kernel] [Resource:cy1_dc0] will be also run.

The current focus seems ok to me regardless of the commit that I made. Why wasn't the ci/cd run?

If my commit is merged, then
Device:qat.*Mode:dpdk would be enough because there will be no generic any more.

@tkatila
Copy link
Contributor Author

tkatila commented Apr 12, 2024

The current focus seems ok to me regardless of the commit that I made. Why wasn't the ci/cd run?

There was/is an issue with the SPR machine. But it should be possible to retry it today.

@tkatila
Copy link
Contributor Author

tkatila commented Apr 12, 2024

Flow passed now. It now runs QAT, IAA, DSA and GPU. SGX is wip in the HW.

@tkatila tkatila changed the title Try with BM SPR host Use SPR BM for e2e Apr 23, 2024
@tkatila tkatila marked this pull request as ready for review April 23, 2024 17:17
.github/workflows/lib-e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/lib-e2e.yaml Outdated Show resolved Hide resolved
Run IAA, DSA, GPU, QAT and SGX tests on it.

Signed-off-by: Tuomas Katila <[email protected]>
@mythi mythi merged commit d0f9aaa into intel:main Apr 25, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants