-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU: Add support for the new xe KMD #1670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few documentation comments/suggestions.
5106971
to
d7e25e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doc suggestions
d7e25e8
to
38d4aa3
Compare
Docs look fine to me now. Somebody else can review the code part... |
I wonder whether it would make sense also to list the driver package names required for L0 (compute+monitoring)?
(As those packages are missing from older distros and their package names are therefore less familiar.) |
In general yes, I just don't know if the GPU plugin is the most sensible place for it. At least I wouldn't put those to the main readme. |
38d4aa3
to
d618213
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1670 +/- ##
==========================================
+ Coverage 39.67% 40.25% +0.57%
==========================================
Files 73 75 +2
Lines 6520 6573 +53
==========================================
+ Hits 2587 2646 +59
+ Misses 3782 3778 -4
+ Partials 151 149 -2 ☔ View full report in Codecov by Sentry. |
c86860f
to
20c99a4
Compare
20c99a4
to
cbe5615
Compare
cbe5615
to
a7a169c
Compare
Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
a7a169c
to
7faa1b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to update e2e/gpu tests to explicitly check xe or i915 but keep the former disabled (SKIP) for now?
I think so. We had an internal discussion that we could add a Flex card or similar to the e2e node and tie one GPU to i915 and another to xe. I'll add the test. |
Plugin can support both i915 and xe drivers dynamically. But having both drivers on same node with RM is not possible. Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Tuomas Katila <[email protected]>
7faa1b4
to
78d5d78
Compare
Co-authored-by: Eero Tamminen <[email protected]> Signed-off-by: Tuomas Katila <[email protected]>
78d5d78
to
95a3c07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also align xelink-sidecar deployment with the new files in the xpu manager project. Signed-off-by: Tuomas Katila <[email protected]>
95a3c07
to
4946b26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look also at the code and that looks OK too.
PS. At some point memory amount checks need to move from using out-of-tree i915 sysfs file, to supporting upstream i915 / Xe KMD ioctl interface, but that does not need to be done in this PR: https://docs.kernel.org/gpu/driver-uapi.html
Separates i915 and xe KMDs via resource name: gpu.intel.com/i915 vs gpu.intel.com/xe. Supports both i915 and xe devices at the same time, but with RM only one type is allowed. Also made some changes to the documentation and NFD rules.
Fixes: #1688