Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU label not added to nodes on Talos because i915 is built into the kernel #1688

Closed
roosmaa opened this issue Mar 12, 2024 · 1 comment · Fixed by #1670
Closed

GPU label not added to nodes on Talos because i915 is built into the kernel #1688

roosmaa opened this issue Mar 12, 2024 · 1 comment · Fixed by #1670
Assignees
Labels
bug Something isn't working

Comments

@roosmaa
Copy link

roosmaa commented Mar 12, 2024

Describe the bug
The intel.feature.node.kubernetes.io/gpu label isn't being applied to the node with NFD on Talos linux.

To Reproduce
Steps to reproduce the behavior: install the gpu plugin on Talos linux.

Expected behavior
The intel.feature.node.kubernetes.io/gpu label is properly added to the nodes.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • OS version: Talos v1.6.6
  • Kernel version: 6.1.80-talos
  • Device plugins version: v0.29.0
  • Hardware info: i7-7700T with iGPU

Additional context
In Talos linux the i915 module is built into kernel. The NodeFeatureRule for intel.feature.node.kubernetes.io/gpu label relies on kernel.loadedmodule which doesn't include builtin modules. Instead the kernel.enabledmodule would be a better option to use in these selectors as it includes both builtin modules and loaded modules.

@tkatila
Copy link
Contributor

tkatila commented Mar 13, 2024

Hello @roosmaa and thanks for the issue. I came across this some time ago as well. A fix is in the pipeline: a3d3e9e .

@tkatila tkatila self-assigned this Mar 13, 2024
@tkatila tkatila added the bug Something isn't working label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants