logging: move away from klogr to ktesting/textlogger #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klog has added ktesting/textlogger and is going to deprecate klogr. The deprecation is going to trigger golangci-lint (staticcheck) errors so rework the logging and move to ktesting/textlogger. The commit also fixes the loglevel setting with operator. Signed-off-by: Mikko Ylinen <[email protected]>
mythi
requested review from
bart0sh,
ozhuraki,
hj-johannes-lee and
tkatila
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
=======================================
Coverage 51.69% 51.69%
=======================================
Files 42 42
Lines 4869 4869
=======================================
Hits 2517 2517
Misses 2206 2206
Partials 146 146 ☔ View full report in Codecov by Sentry. |
tkatila
reviewed
Nov 20, 2023
tkatila
approved these changes
Nov 20, 2023
hj-johannes-lee
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klog has added ktesting/textlogger and is going to deprecate klogr. The deprecation is going to trigger golangci-lint (staticcheck) errors so rework the logging and move to ktesting/textlogger.
The commit also fixes the loglevel setting with operator.
Split from #1584