Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade to k8s.io v1.29 #1584

Merged
merged 2 commits into from
Dec 4, 2023
Merged

go.mod: upgrade to k8s.io v1.29 #1584

merged 2 commits into from
Dec 4, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Nov 3, 2023

Just to trigger tests early on...

@mythi
Copy link
Contributor Author

mythi commented Nov 6, 2023

ci: use Go 1.21.x for kind tests too

retitle: 'for envtest tests'

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3739fcb) 51.75% compared to head (508b447) 51.69%.

❗ Current head 508b447 differs from pull request most recent head 1e92918. Consider uploading reports for the commit 1e92918 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   51.75%   51.69%   -0.07%     
==========================================
  Files          42       42              
  Lines        4869     4869              
==========================================
- Hits         2520     2517       -3     
- Misses       2204     2206       +2     
- Partials      145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mythi mythi force-pushed the PR-2023-052 branch 2 times, most recently from 29b8eb7 to 03f0930 Compare November 7, 2023 10:46
@mythi mythi force-pushed the PR-2023-052 branch 2 times, most recently from 258a91b to 3b614ff Compare November 17, 2023 04:55
@mythi mythi force-pushed the PR-2023-052 branch 2 times, most recently from de48f33 to 4e4c7a7 Compare November 29, 2023 06:46
@mythi mythi changed the title WIP: go.mod: upgrade to k8s.io v1.29 go.mod: upgrade to k8s.io v1.29 Nov 29, 2023
@mythi mythi marked this pull request as ready for review November 29, 2023 06:46
mythi added 2 commits December 4, 2023 08:44
k8s v1.29 depends on Go 1.21.3 or later. Without an explicit
go-version-file: go.mod with 'go 1.21.3' we are seeing failures
in different CI steps.

Make sure all setup-go workflows use Go version from go.mod.

Signed-off-by: Mikko Ylinen <[email protected]>
@tkatila tkatila merged commit b03ac67 into intel:main Dec 4, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants