-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add link to helper docs when alternate contains patterns #1674
refactor: add link to helper docs when alternate contains patterns #1674
Conversation
Looks good to me! (tagging @terriko for workflow approval) You could remove the |
I don't know what is the true practice about |
I'm approving the github actions workflow to run tests. We haven't used the |
renaming PR for gitlint |
43f93e6
to
464d0ee
Compare
all "<", ">" removed |
hi @snosratiershad i don't think |
Hey @b31ngd3v, thanks for the link, it was very helpful and I didn't know anything about it. I will fix it. |
@terriko, I discovered pipelines and don't think checks failure are related to changes in this PR, if I'm wrong please let me know and I will fix them. |
Updating the branch to re-run tests. I'll try to get back to look at this after my meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the tests are behaving again! (I think you got hit with the conflict in the exploited cves patch and the reportlab test patch). Thank you for doing this, I'll go ahead and get these merged now.
As discussed in this issue and this PR, I added
# Alternate optional contains patterns, see <link to helper script docs> for more details
in checkers where we have commented out strings inCONTAINS_PATTERNS
with this link to helper script docs.