Updated existing checkers using Helper Script

[peb-peb]

• add # Alternate optional contains patterns, see <link to helper script docs> for more details

checkers checked against the Helper Script:

• avahi
• bash
• bind
• binutils (not scanned - already has good signatures)
• busybox
• bzip2
• cups
• curl
• dnsmasq
• dovecot
• dpkg --not scanned
• expat --not getting the exact vendor-product pair
• ffmpeg --breaks the script
• freeradius
• gcc
• gimp
• glibc
• gnupg
• gstreamer
• haproxy
• hostpad
• icecast
• icu fix: icu checker #1208
• irissi
• kerberos
• libarchive (no proper strings available for CONTAINS_PATTERNS)
• libcurl
• libdb
• libgcrypt
• libjpeg
• libnss (not scanned - already has good signatures)
• linsndfile
• libsoup (no proper strings available for CONTAINS_PATTERNS)
• libssh2
• libtiff
• libvirt
• libxslt
• lighttpd
• logrotate
• mariadb
• memchand
• mysql
• ncurses
• nessus
• netpbm
• nginx
• node
• ntp
• openafs
• openjpeg
• openldap
• openssh
• openssl
• openvpn
• p7zip
• png
• polarssl_fedora
• postgresql
• pspp
• python
• qt
• radare2
• rsyslog
• samba
• sqlite
• strongswan
• subversion
• syslogng
• systemd
• tcpdump
• varnish
• webkitgtk
• wireshark
• wpa_supplicant
• xerces
• xml2
• zlib

[peb-peb]

While looking for common strings in bash, I found about ~70 common stings. I choose only a few to include here. Should we comment all the common strings? (I was going for about 4-5 strings)

[codecov-commenter]

Codecov Report

Merging #1189 (eaed3cf) into main (3ccda67) will increase coverage by 1.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   79.31%   80.84%   +1.52%     
==========================================
  Files         271      271              
  Lines        4908     4908              
  Branches      593      593              
==========================================
+ Hits         3893     3968      +75     
+ Misses        866      797      -69     
+ Partials      149      143       -6     

Flag	Coverage Δ
longtests	80.84% <100.00%> (+1.52%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cve_bin_tool/checkers/dnsmasq.py	100.00% <ø> (ø)
cve_bin_tool/checkers/libsndfile.py	100.00% <ø> (ø)
test/test_data/bzip2.py	100.00% <ø> (ø)
test/test_data/cups.py	100.00% <ø> (ø)
test/test_data/curl.py	100.00% <ø> (ø)
test/test_data/dovecot.py	100.00% <ø> (ø)
test/test_data/freeradius.py	100.00% <ø> (ø)
test/test_data/gcc.py	100.00% <ø> (ø)
test/test_data/gnupg.py	100.00% <ø> (ø)
test/test_data/irssi.py	100.00% <ø> (ø)
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccda67...eaed3cf. Read the comment docs.

[terriko]

Looking pretty good, let's just make sure we've got an explanation and/or a link to docs about the helper script so people can see why there's commented out values.

[peb-peb]

# Alternate optional contains patterns, see <link to helper script docs> for more details

I'll update it it once I finish writing up the docs.

[peb-peb]

        # Make sure the product and version are in the results
        assert (
            product in list_products
        ), f"""{product} not found in {package_name}.
        The checker signature or url may be incorrect."""
>       assert version in list_versions
E       AssertionError: assert '8.4.1' in {'8.3.1'}

test/test_scanner.py:262: AssertionError

after scanning a few files, found that r"gcc ([0-9]+\.[0-9]+(\.[0-9]+)?)" is not consistent and changed it.
Also, I was not able to find any appropriate version pattern for debian packages. (I've added a note at top for this)

[peb-peb]

for gnupg, I am receiving this error: (all tests seems to fail)

        # Make sure the product and version are in the results
>       assert (
            product in list_products
        ), f"""{product} not found in {package_name}.
        The checker signature or url may be incorrect."""
E       AssertionError: gnupg not found in gnupg-1.4.23nb11.tgz.
E                 The checker signature or url may be incorrect.
E       assert 'gnupg' in set()

test/test_scanner.py:258: AssertionError

this is what my checker looks like:

class GnupgChecker(Checker):
    CONTAINS_PATTERNS = [
        r"# \(Use \"gpg --import-ownertrust\" to restore them\)",
        r"Comment: Use \"gpg --dearmor\" for unpacking",
        # r"standalone revocation - use \"gpg --import\" to apply",
        # r"you can update your preferences with: gpg --edit-key %s updpref save",
    ]
    FILENAME_PATTERNS = [
        "gpg",  # to match gpg, gpg2, gpg1
        # "g13",
    ]
    VERSION_PATTERNS = [
        r"gpg\.conf\-([0-9]+\.[0-9]+\.[0-9]+)",
        # r"(GnuPG) ([0-9]+\.[0-9]+\.[0-9]+)",
        # r"GNU Privacy Guard's OpenPGP server ([0-9]+\.[0-9]+\.[0-9]+) ready",
        # r"GNU Privacy Guard's G13 server ([0-9]+\.[0-9]+\.[0-9]+) ready",
    ]
    VENDOR_PRODUCT = [("gnupg", "gnupg")]

and the test_data for it is:

mapping_test_data = [
    {
        "product": "gnupg",
        "version": "2.2.27",
        "version_strings": ["gpg.conf-2.2.27"],
    },
    {
        "product": "gnupg",
        "version": "2.2.23",
        "version_strings": ["gpg.conf-2.2.23"],
    },
]

package_test_data = [
    {
        "url": "http://mirror.centos.org/centos/7/os/x86_64/Packages/",
        "package_name": "gnupg2-2.0.22-5.el7_5.x86_64.rpm",
        "product": "gnupg",
        "version": "2.0.22",
    },
    {
        "url": "http://mirror.centos.org/centos/8/BaseOS/x86_64/os/Packages/",
        "package_name": "gnupg2-2.2.20-2.el8.x86_64.rpm",
        "product": "gnupg",
        "version": "2.2.20",
    },
    {
        "url": "https://download-ib01.fedoraproject.org/pub/fedora/linux/releases/34/Everything/x86_64/os/Packages/g/",
        "package_name": "gnupg1-1.4.23-15.fc34.x86_64.rpm",
        "product": "gnupg",
        "version": "1.4.23",
    },
    {
        "url": "https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/amd64/9.1/All/",
        "package_name": "gnupg-1.4.23nb11.tgz",
        "product": "gnupg",
        "version": "1.4.23",
    },
]

I am not pushing this in this pr due to the errors :(