LLM: add fuse optimization for Mistral. #9184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkvision
reviewed
Oct 16, 2023
| @@ -348,4 +348,10 @@ def optimize(model): | |||
| convert_forward(model, | |||
| module.AquilaRMSNorm, | |||
| llama_rms_norm_forward) | |||
| elif model.config.model_type == "mistral": | |||
| modeling_module_name = model.__class__.__module__ | |||
| module = importlib.import_module(modeling_module_name) | |||
There was a problem hiding this comment.
where's attention forward?
hkvision
approved these changes
Oct 16, 2023
hkvision
reviewed
Oct 16, 2023
Comment on lines
89
to
91
| key_states, | ||
| position_ids, | ||
| "mistral") |
There was a problem hiding this comment.
will check this.
liu-shaojun
pushed a commit
that referenced
this pull request
Mar 25, 2024
* add fuse optimization for mistral. * fix. * fix * fix style. * fix. * fix error. * fix style. * fix style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add fuse rope and norm optimization for Mistral-7B model.
1. Why the change?
Add fuse rope and norm optimization for XPU, to avoid unnecessary copies and decrease the latency.
2. User API changes
None.
3. How to test?