Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orca: Add 2 NCF PyTorch examples with data_loader or XShards as inputs. #5691
Orca: Add 2 NCF PyTorch examples with data_loader or XShards as inputs. #5691
Changes from 64 commits
84e2887
45a0b16
64e9826
617eb05
dcae8fb
bd1b747
ec2085d
7a9734c
35d4abc
c7a1302
616ae22
995fb38
89af496
2dd3145
01a15b6
c023cad
4fb75d3
4a12f12
c307b67
98a5704
c3e38a8
d161990
84eef4e
2d9f565
7eae073
6ce1214
2501d73
36129c1
cadffaa
3192856
987c631
c38600f
2f7acfa
50cee71
0e9d396
72facb9
05f8ee6
11a7681
caec95e
f84dee8
c60a99e
447f22c
88448d2
8c31003
602a6b2
5bc8227
780dc59
a08de8e
9248258
94ee598
0b72cbf
e2e0c8e
d117ca9
036b41f
0d99df2
d7d07ed
222d984
bc983d1
f028a29
0654723
70c794d
29762f3
b9f4835
0b6964a
eaa0623
fc86575
dc6bea6
328bea3
63e7278
4854b52
05a6dd5
6330bb9
cd47319
85b8fe0
84b5c61
15bd60e
8fd7f9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put user, item in the args directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move import scipy to local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
num_workers=4 in the original code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch_size=batch_size, and put 256 in fit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing batch_size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the original script trains for 20 epochs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
batch_size=256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add one more print to say it is evaluation results?