Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Substrate dependency import to polkadot release branches #694

Closed
haerdib opened this issue Mar 24, 2022 · 7 comments · Fixed by #720
Closed

Switch Substrate dependency import to polkadot release branches #694

haerdib opened this issue Mar 24, 2022 · 7 comments · Fixed by #720
Assignees

Comments

@haerdib
Copy link
Contributor

haerdib commented Mar 24, 2022

We keep running into problems due to substrate versions dependencies being updated.

We have the following options:

  1. master branch (how it's currently done)
    • (+) Would theoretically give us the flexibility to update via cargo update --precise xxx-commit. Not possible currently due to the necessity of specifying the dev version (4.0.0-dev))
    • (-) Due to the versioning, we are regularly forced to update (worker can not be built anymore).
  2. monthly tags
    • (-) the node would need to follow suit
  3. polkadot branches (like parachain)
    • (+) we could follow the version of our parachain
  4. specific commits
    • (-) the node would need to follow suit
@haerdib haerdib added the F9-question Further information is requested label Mar 24, 2022
@clangenb
Copy link
Contributor

clangenb commented Mar 24, 2022

I have had enough of the suddenly breaking builds by just referencing the master branch. If these breakages occur in the wrong moment, they pose a serious hazard to potential deadlines and planing.

It seems that the polkadot repository determines what other options we have. I will start by excluding options systematically not possible:

  1. monthly-tags: not possible as the polkadot repository does not have this. The only tags contained there are release-v0.9.18 etc., which references substrate's polkadot-v0.9.18 branch.
  2. specific commits: This is not possible because the polkadot-deps would still reference substrate with branch = master. Cargo cannot resolve the dependency as the same even if the referenced commit exists in master branch. Hence, we get duplicate imports.

Therefore, this leaves only the status quo or using polkadot-release branches.

@haerdib
Copy link
Contributor Author

haerdib commented Mar 25, 2022

Ajuna has the problem that they depend on the orml-pallets, which also points to polkadot releases.

@brenzi
Copy link
Collaborator

brenzi commented Mar 29, 2022

polkadot releases could work well, I think because that's how parity solves the same problem on their side

@gaudenzkessler
Copy link
Contributor

Rebase of teeracle.

@haerdib
Copy link
Contributor Author

haerdib commented Mar 29, 2022

So this task now includes the bump of the worker and all the dependent repositories, excluding solochain and parachain, which are tasked in integritee-network/parachain#82

@haerdib haerdib removed the F9-question Further information is requested label Mar 29, 2022
@haerdib haerdib changed the title Substrate dependency import Switch Substrate dependency import to polkadot release branches Mar 29, 2022
@echevrier
Copy link
Contributor

The latest substrate polkadot branch ( polkadot-v0.9.18) is behind the current substrate version and does not have the fix for the full_crypto std bug (paritytech/substrate#11005) -> worker, sgx-runtime, teeracle will not compile.
@brenzi and @clangenb : Should we wait for the next polkadot release ? Note: Integritee node and pallets are already "downgraded" to polkadot-v0.9.18

@clangenb
Copy link
Contributor

v0.9.19 is out and would include the fix we need. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants