Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sp-core's full_crypto feature flag breaks no_std builds. #11005

Closed
clangenb opened this issue Mar 10, 2022 · 2 comments · Fixed by #11006
Closed

sp-core's full_crypto feature flag breaks no_std builds. #11005

clangenb opened this issue Mar 10, 2022 · 2 comments · Fixed by #11006
Assignees
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@clangenb
Copy link
Contributor

Since commit: bfc6fb4

This is because, the secp256k1 global-context feature implies std:

secp256k1 = { version = "0.21.2", default-features = false, features = ["recovery", "global-context"], optional = true }

I currently lack the overview if disabling global-context in full_crypto would be a reasonable choice. My intuition would say it is enough for SGX-enclave because we are already in an enhanced security environment.

@bkchr
Copy link
Member

bkchr commented Mar 10, 2022

Ty for the report. It will be fixed with: #11006

@clangenb
Copy link
Contributor Author

Wow, thanks for the immediate fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants