Upgrade go-github to v39 #905
Conversation
|
Hi @lauraseidler, with this change in release 4.15.0, I think ListRepositoryAccessRunnerGroup is referenced in resource_github_actions_runner_group. I assume this needs to be updated now? |
|
Yeah, looks like it. Though I'm unsure what to pass there - I guess technically, this call should be looped to make sure to fetch all pages? Or we pass the default from GitHub (30 per page, page 1), as that would keep the current behaviour as is, and then full pagination can be implemented separately? Thoughts @xun-guo-anzx? |
|
@lauraseidler here is an example how we can handle pagination. We can pass 30 per page as a start point, then fetch the rest of pages via a loop. Hope this can be useful for you. |
|
@xun-guo-anzx what's the behavior if |
It should work the same as current behaviour, which only fetches the first 30 repository from the list |
lauraseidler
force-pushed
the
go-github-v39
branch
from
f875235 to
8f6abc2
Compare
|
I've rebased this now and am passing Personally, I would stick to this as the scope of this PR, as it should keep the behaviour exactly the same as before and only does the update, which should unblock both #649 and also implementing pagination for this in a follow up PR. Does that work @xun-guo-anzx @kfcampbell? |
|
Yep that sounds good to me! |
This should allow moving forward with #649 (I'll provide another PR).
Release: https://github.com/google/go-github/releases/tag/v39.0.0 - the only breaking changes are in relation to
ListRepositoryAccessRunnerGroup, which this provider isn't using as far as I can see.Note: I'm not really a Go pro, so in case I messed something up, please let me know so I can learn :)