Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List Options for ListRepositoryAccessRunnerGroup #2086

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Add List Options for ListRepositoryAccessRunnerGroup #2086

merged 1 commit into from
Sep 9, 2021

Conversation

xun-guo-anzx
Copy link
Contributor

Fix #2085 . Add List Options for ListRepositoryAccessRunnerGroup to support fetching full list of access repositories. Also update unit tests accordingly.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #2086 (7d01f4d) into master (ee49f8e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2086   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         109      109           
  Lines        9720     9724    +4     
=======================================
+ Hits         9504     9508    +4     
  Misses        150      150           
  Partials       66       66
Impacted Files Coverage Δ
github/actions_runner_groups.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee49f8e...7d01f4d. Read the comment docs.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Sep 8, 2021
gmlewis
gmlewis approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @xun-guo-anzx !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp September 8, 2021 11:49
@xun-guo-anzx
Copy link
Contributor Author

Thanks @gmlewis . Can I request a release after this is merged?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 9, 2021

Thanks @gmlewis . Can I request a release after this is merged?

Sure, @xun-guo-anzx - maybe @Parker77 has time to review this and we can move forward with the new release.

Parker77
Parker77 approved these changes Sep 9, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 9, 2021

LGTM.

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit ecb86f7 into google:master Sep 9, 2021
@gmlewis gmlewis mentioned this pull request Sep 9, 2021
Merged
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 9, 2021

@xun-guo-anzx - https://github.com/google/go-github/releases/tag/v39.0.0 has been released with this change.

@lauraseidler lauraseidler mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parker77 Parker77 Parker77 approved these changes

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ListOptions in ListRepositoryAccessRunnerGroup
3 participants
@xun-guo-anzx @gmlewis @Parker77